Skip to content

Large file upload task - Add UploadResult object#397

Merged
nikithauc merged 8 commits into3.0.0from
nikithauc/largeFile-uploadreasult
Mar 4, 2021
Merged

Large file upload task - Add UploadResult object#397
nikithauc merged 8 commits into3.0.0from
nikithauc/largeFile-uploadreasult

Conversation

@nikithauc
Copy link
Copy Markdown
Contributor

Fixes #359.

  • Change the condition to mark upload as completed.
  • Added a UploadResult class.
  • Added a getUploadSession() function.
  • Added isCancelled property to LargeUploadSession interface.

Comment thread src/middleware/AuthenticationHandler.ts Outdated
Comment thread src/middleware/AuthenticationHandler.ts Outdated
Comment thread src/tasks/FileUploadUtil/UploadResult.ts Outdated
Comment thread src/tasks/LargeFileUploadTask.ts
Comment thread src/tasks/LargeFileUploadTask.ts
Comment thread src/tasks/LargeFileUploadTask.ts
Comment thread docs/tasks/LargeFileUploadTask.md
Comment thread src/tasks/FileUploadUtil/UploadResult.ts Outdated
Comment thread src/tasks/FileUploadUtil/UploadResult.ts Outdated
Comment thread src/tasks/FileUploadUtil/UploadResult.ts Outdated
Comment thread src/tasks/FileUploadUtil/UploadResult.ts Outdated
@nikithauc nikithauc merged commit 61fe3dd into 3.0.0 Mar 4, 2021
};
const uploadTask = new LargeFileUploadTask(getClient(), fileObj, uploadSession, options);
const status201 = {
status: 200,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

201?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise this test is exactly the same as the one below.

@nikithauc nikithauc deleted the nikithauc/largeFile-uploadreasult branch May 3, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LargeFileUploadTask is ending with PassThrough stream instead of saying JSON response with id

3 participants